Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added asdf strap #18

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Added asdf strap #18

merged 1 commit into from
Jul 6, 2019

Conversation

fvumbaca
Copy link
Contributor

@fvumbaca fvumbaca commented Jul 4, 2019

Added support for asdf version manager.

strapped:
  repo: repo.strapped.sh

brew:
  packages:
    - { name: asdf }

asdf:
  plugins:
    - { name: clojure, url: https://github.com/halcyon/asdf-clojure.git }
    - { name: elixir,  url: https://github.com/asdf-vm/asdf-elixir.git }
  versions:
    - { name: clojure, version: 1.9.0 }
    - { name: elixir,  version: 1.8.2, dir: ~/projects/i-need-a-specific-version }

@fvumbaca fvumbaca added the enhancement New feature or request label Jul 4, 2019
@fvumbaca
Copy link
Contributor Author

fvumbaca commented Jul 5, 2019 •
edited
Loading

@tk8817 before i merge this in, you mentioned that there should be a version bump. Do we version bump on added straps? I personally feel the straps fall under their own versions and the "main" version is related to the strapped command.

Thoughts?

cc: @MatthewNielsen27

@azohra
Copy link
Owner

azohra commented Jul 5, 2019

To me a new strap means

  1. Updated docs website
  2. New Strap entry in master strap repo
  3. New functionality available for users of master strap repo

Ideally I want a way to let our users know when new functionality is available, and to let the media know what that new functionality is.

I agree the versions are not related, but I think we should do a minor bump of strapped itself as a means of having a release entry marking the new strapped repo feature.

An alternate would be to move the straps to another repo and do releases there.

@fvumbaca
Copy link
Contributor Author

fvumbaca commented Jul 5, 2019

Looking at a pr to the homebrew-core repo, they have separated the available packages from the tool, but there is no repo-wide version. The difference I see here is homebrew has a mechanism to discover changes to their repository where we do not besides our documentation. Maybe the problem I am seeing is one of scale - but I do agree there will be issues around discovering new or updated straps.

With our current setup I agree with you that we should bump the minor version. I will update this pr to include that version bump.

I will also raise an issue to discuss this further because moving forward I believe this could cause more work and confusion.

@azohra
Copy link
Owner

azohra commented Jul 6, 2019

@fvumbaca - aligned 100%, lets find a better way forward for future PRs.

@azohra azohra self-requested a review July 6, 2019 00:16
@azohra azohra added the strap label Jul 6, 2019
@azohra azohra added this to the v0.3 milestone Jul 6, 2019
azohra
azohra approved these changes Jul 6, 2019
View reviewed changes
Copy link
Owner

@azohra azohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Lets bump version and lets generate a release.

@fvumbaca fvumbaca merged commit 0e85cdd into master Jul 6, 2019
@azohra azohra deleted the asdf-strap branch April 24, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azohra azohra azohra approved these changes

Assignees

@azohra azohra

@fvumbaca fvumbaca

Labels
enhancement New feature or request strap
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@fvumbaca @azohra